Repository navigation
Conversation
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
Author
|
Fixes #8748 |
Author
|
This is a temporary fix that I propose to fix the ICE, fn main() {
let _ = [0; {
let x = 1;
if let Some(x) = Some(1) { x } else { 1 }
}];
}but, I'm not unsure whether or not this code can actually be linted at all I also propose this fix now because I'm not coding much atm and I didn't want to let the ICE unfixed for too long |
Author
I'll do it when coming home from work 👍 |
Contributor
|
@bors r+ Thanks! |
Contributor
|
📌 Commit 0a7f19b has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for making Clippy better!
changelog: Fix ICE #8748 in shadow.rs