Skip to content

Fix documentation of eval_order_dependence - #7634

Merged
bors merged 1 commit into
rust-lang:masterfrom
chansuke:update-eval-order-depends-docs
Sep 6, 2021
Merged

bors merged 1 commit into
rust-lang:masterfrom
chansuke:update-eval-order-depends-docs

Conversation

@chansuke

@chansuke chansuke commented Sep 4, 2021 •

Copy link
Copy Markdown
Contributor

Fixes #7624.

changelog: fix documentation of eval_order_dependence

@rust-highfive

Copy link
Copy Markdown

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 4, 2021
@Manishearth

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 5, 2021

Copy link
Copy Markdown
Contributor

📌 Commit b2f01ef has been approved by Manishearth

@bors

bors commented Sep 5, 2021

Copy link
Copy Markdown
Contributor

⌛ Testing commit b2f01ef with merge b5b5185...

bors added a commit that referenced this pull request Sep 5, 2021
…shearth

Fix documentation of eval_order_dependence

Fixes #7624.
@bors

bors commented Sep 5, 2021

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-action_test

@matthiaskrgr

Copy link
Copy Markdown
Member

@chansuke you'll need a changelog entry in your pr text, if you just add something like

changelog: fix documentation of eval_order_dependence

under "Fixes #7624." (it needs to be a separate line) on github, that should do it.

@Manishearth

Copy link
Copy Markdown
Member

@bors r+

Added it myself

@bors

bors commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors

bors commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

📌 Commit b2f01ef has been approved by Manishearth

@bors

bors commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

⌛ Testing commit b2f01ef with merge 17294b8...

@bors

bors commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 17294b8 to master...

@bors
bors merged commit 17294b8 into rust-lang:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated eval_order_dependence documentation

5 participants