Skip to content

Refactor: arrange lints in misc_early module - #7166

Merged
bors merged 11 commits into
rust-lang:masterfrom
TaKO8Ki:refactor_misc_early_module
May 6, 2021
Merged

bors merged 11 commits into
rust-lang:masterfrom
TaKO8Ki:refactor_misc_early_module

Conversation

@TaKO8Ki

@TaKO8Ki TaKO8Ki commented May 4, 2021 •

Copy link
Copy Markdown
Member

This PR arranges misc_early lints so that they can be accessed more easily.
Basically, I refactored them following the instruction described in #6680.

cc: @Y-Nak, @flip1995, @magurotuna

changelog: Move lints in misc_early module into their own modules.

@rust-highfive

Copy link
Copy Markdown

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 4, 2021
@llogiq

llogiq commented May 6, 2021

Copy link
Copy Markdown
Contributor

Thank you!

@bors r+

@bors

bors commented May 6, 2021

Copy link
Copy Markdown
Contributor

📌 Commit 3fbb060 has been approved by llogiq

@bors

bors commented May 6, 2021

Copy link
Copy Markdown
Contributor

⌛ Testing commit 3fbb060 with merge 7191675...

@bors

bors commented May 6, 2021

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 7191675 to master...

@bors
bors merged commit 7191675 into rust-lang:master May 6, 2021
@TaKO8Ki
TaKO8Ki deleted the refactor_misc_early_module branch May 6, 2021 08:09
@flip1995

flip1995 commented May 6, 2021

Copy link
Copy Markdown
Member

Thanks for splitting up those lints! This will need a follow up PR though. The main issue with the misc and misc_early modules was that they combine multiple unrelated lints. Those lints should be integrated in existing other lint passes or get their own lint passes. For example the MIXED_CASE_HEX_LITERALS lint would fit into the literal_representation.rs module. The end goal would be to get rid of the misc_early and misc modules completely.

@TaKO8Ki

TaKO8Ki commented May 6, 2021 •

Copy link
Copy Markdown
Member Author

@flip1995
Sure! I'm going to open a new tracking issue about that and work on it.

@flip1995

flip1995 commented May 6, 2021

Copy link
Copy Markdown
Member

Thanks! If you're unsure about lints, just ask or put them where you see the best fit for them and we can look at it during review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants