Skip to content

Replace cfg_attr(rustfmt... with rustfmt::skip - #2823

Merged
oli-obk merged 1 commit into
rust-lang:masterfrom
flip1995:thingies_things
Aug 8, 2018
Merged

oli-obk merged 1 commit into
rust-lang:masterfrom
flip1995:thingies_things

Conversation

@flip1995

Copy link
Copy Markdown
Member

Fixes #2822

thingies replaced!

@oli-obk

oli-obk commented May 30, 2018

Copy link
Copy Markdown
Contributor

still triggering some errors on travis

@flip1995

Copy link
Copy Markdown
Member Author

This is a rustc problem. If you enable the rust_2018_preview and the tool_attributes feature, the tool_attributes stop working, see playground. I'm looking into this tomorrow and either open a PR or an issue.

@mati865

mati865 commented Jun 1, 2018

Copy link
Copy Markdown
Member

😞
The migration took it's first casualty.

@mati865

mati865 commented Jul 30, 2018

Copy link
Copy Markdown
Member

This PR will be unblocked when rust-lang/rust#52841 lands.

@phansch phansch closed this Aug 6, 2018
@phansch phansch reopened this Aug 6, 2018
@mati865

mati865 commented Aug 8, 2018

Copy link
Copy Markdown
Member

CI passed

@oli-obk
oli-obk merged commit d722489 into rust-lang:master Aug 8, 2018
@flip1995
flip1995 deleted the thingies_things branch September 24, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants