[ada4a]

Basically continuing the work in #6680

Honestly I think the lint could also be run on (trait) impl items, but I didn't implement that because of the feature freeze. If that is deemed okay to add in this PR though, I could happily do so.

changelog: none

[rustbot]

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[github-actions]

No changes for 54c52e2

[ada4a]

I'm still not..

@rustbot label -S-blocked -A-lint +S-waiting-on-review
@rustbot note remove Feature-freeze

[ada4a]

Hm, somehow extracting the lint to a separate module was fine, but moving it to another lint pass was not? I even tried to create a separate FunctionsEarly pass with just this lint, but that didn't work either..

[y21]

You'll need to register it as an early lint pass as well:

rust-clippy/clippy_lints/src/lib.rs

Line 559 in 9a2076e

store.register_late_pass(move |tcx| Box::new(functions::Functions::new(tcx, conf)));

But that will probably not work since Functions::new needs a TyCtxt which is not available at that point, so you'll likely have to split it up into a separate EarlyFunctions lint pass. You can look at attrs/mod.rs. That "group" also has both early and late lints

[ada4a]

Thank you very much! With that, everything worked out perfectly

[y21]

Thanks, LGTM! Can you squash the commits?

[ada4a]

squashed (and rebased)!