Skip to content

Make restriction lint's use span_lint_and_then (q -> w) - #13145

Merged
bors merged 2 commits into
rust-lang:masterfrom
xFrednet:07797-restriction-and-then-why
Aug 6, 2024
Merged

bors merged 2 commits into
rust-lang:masterfrom
xFrednet:07797-restriction-and-then-why

Conversation

@xFrednet

Copy link
Copy Markdown
Contributor

This migrates a few restriction lints to use span_lint_and_then. This change is motivated by #7797.

I've also cleaned up some lint message. Mostly minor stuff. For example: suggestions with a longer message than "try" now use SuggestionStyle::ShowAlways


cc: #7797

sister PR of: #13136

changelog: none

@rustbot

rustbot commented Jul 22, 2024

Copy link
Copy Markdown
Collaborator

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 22, 2024
@xFrednet xFrednet changed the title Make restriction lint's use span_lint_and_then (q -> w) Make restriction lint's use span_lint_and_then (q -> w) Jul 23, 2024
@bors

bors commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #13144) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet
xFrednet force-pushed the 07797-restriction-and-then-why branch from a035915 to 514770b Compare July 26, 2024 08:03
@bors

bors commented Jul 27, 2024

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #13168) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet
xFrednet force-pushed the 07797-restriction-and-then-why branch from 514770b to 4bf4c47 Compare July 27, 2024 11:45
@Jarcho

Jarcho commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Thank you. @bors r+

@bors

bors commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

📌 Commit 4bf4c47 has been approved by Jarcho

It is now in the queue for this repository.

@bors

bors commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

⌛ Testing commit 4bf4c47 with merge cfb3881...

@bors

bors commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing cfb3881 to master...

@bors
bors merged commit cfb3881 into rust-lang:master Aug 6, 2024
@xFrednet
xFrednet deleted the 07797-restriction-and-then-why branch August 6, 2024 07:13
@xFrednet xFrednet added the G-performance-project Goal: For issues and PRs related to the Clippy Performance Project label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

G-performance-project Goal: For issues and PRs related to the Clippy Performance Project S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants