Repository navigation
Allow cast lints in macros - #12631
Merged
Merged
Conversation
Removed the `from_expansion` guard clause for cast lints, so that these warnings can be generated for internal macros.
Collaborator
rustbot
added
the
S-waiting-on-review
blyxyas
approved these changes
Apr 4, 2024
blyxyas
left a comment
blyxyas
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! ❤️
This would change the outcome so that no lints were processed on proc macros. But hey, I don't think that we want to run cast lints on proc macros anyways haha =^w^=
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #11738
Removed the
from_expansionguard clause for cast lints, so that these warnings can be generated for internal macros.changelog: allow
castlints in macros