Skip to content

Add allow_attribute lint - #10481

Merged
bors merged 7 commits into
rust-lang:masterfrom
blyxyas:allow_attribute
Mar 16, 2023
Merged

Add allow_attribute lint#10481
bors merged 7 commits into
rust-lang:masterfrom
blyxyas:allow_attribute

Conversation

@blyxyas

@blyxyas blyxyas commented Mar 10, 2023 •
edited by xFrednet
Loading

Copy link
Copy Markdown
Member

Fixes #10468

changelog: new lint: [allow_attributes]
#10481

@rustbot

rustbot commented Mar 10, 2023

Copy link
Copy Markdown
Collaborator

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 10, 2023
xFrednet
xFrednet reviewed Mar 11, 2023
View reviewed changes

@xFrednet xFrednet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, I've left some comments, how I believe the code can be improved. You're welcome to ask if you have any questions :)

Comment thread clippy_lints/src/allow_attribute.rs Resolved
Comment thread clippy_lints/src/allow_attribute.rs Resolved
Comment thread clippy_lints/src/allow_attribute.rs Resolved
Comment thread clippy_lints/src/allow_attribute.rs Resolved
Comment thread clippy_lints/src/allow_attribute.rs Resolved
Comment thread tests/ui/allow_attribute.fixed Resolved
Comment thread tests/ui/allow_attribute.rs Resolved
xFrednet
xFrednet reviewed Mar 15, 2023
View reviewed changes

@xFrednet xFrednet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Four nits, that should be simple to fix and then this should be ready for merge. Thank you for the swift updates! :D

Comment thread clippy_lints/src/allow_attribute.rs Resolved
Comment thread CHANGELOG.md Resolved
Comment thread clippy_lints/src/allow_attribute.rs Resolved
Comment thread tests/ui/allow_attribute.stderr Resolved
@xFrednet

xFrednet commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

This version looks good to me, thank you for implementing this lint! I like it :)

There was still a small formatting NIT where I don't think it was worth it to leave a comment about. I fixed up your last commit. Hope that's okay with you :)

@bors r+

@bors

bors commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

📌 Commit 1cab0cb has been approved by xFrednet

It is now in the queue for this repository.

@bors

bors commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit 1cab0cb with merge 5afa93b...

@bors

bors commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 5afa93b to master...

1 similar comment
@bors

bors commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 5afa93b to master...

@bors
bors merged commit 5afa93b into rust-lang:master Mar 16, 2023
This was referenced Mar 16, 2023
Merged
Merged
Merged
Merged
Closed
@blyxyas
blyxyas deleted the allow_attribute branch October 5, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xFrednet xFrednet xFrednet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@xFrednet xFrednet

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lint: Suggestion #[expect] over #[allow]

4 participants

@blyxyas @rustbot @xFrednet @bors