Skip to content

Move our paths over to diagnostic items #5393

New issue
New issue
Closed
rust-lang/rust
#142787
Closed
Move our paths over to diagnostic items#5393
rust-lang/rust
#142787
Labels
C-an-interesting-projectCategory: Interesting projects, that usually are more involved design/code wise.C-tracking-issueCategory: Tracking IssueE-mediumCall for participation: Medium difficulty level problem and requires some initial experience.G-performance-projectGoal: For issues and PRs related to the Clippy Performance Project

Description

@Manishearth
Manishearth
opened on Mar 30, 2020

Currently we have a ton of hardcoded paths for stdlib types.

Rustc has a way of tagging types for diagnostics via a "diagnostic item" API (rust-lang/rust#60966). We should go through rustc and tag most of these diagnostic items, and replace the hardcoded paths with hardcoded diagnostic item names instead. We can still keep the path framework around for rapid prototyping, but have a comment recommending people switch to diagnostic items whenever possible.

Activity

  1. Manishearth
    added
    E-mediumCall for participation: Medium difficulty level problem and requires some initial experience.
    C-an-interesting-projectCategory: Interesting projects, that usually are more involved design/code wise.
    on Mar 30, 2020
  2. flip1995
    added
    C-tracking-issueCategory: Tracking Issue
    on Mar 30, 2020

  3. flip1995 commented on Mar 30, 2020

    @flip1995
    flip1995
    on Mar 30, 2020
    Member

    Marking it as tracking issue and pinning it, since this is probably done in multiple steps.

  4. flip1995
    pinned this issue on Mar 30, 2020
  5. bors
    added a commit that references this issue on Apr 14, 2020

    Auto merge of #5449 - phansch:diagnostic-items, r=matthiaskrgr

    81b3e70
  6. Dylan-DPC-zz
    added a commit that references this issue on Apr 22, 2020

    Rollup merge of rust-lang#71414 - phansch:more-diagnostic-items, r=Ma…

    01fdc88
  7. phansch
    added a commit that references this issue on Apr 23, 2020

    More diagnostic items

    c3acaf3
  8. bors
    added 2 commits that reference this issue on Apr 23, 2020

    Auto merge of #5509 - phansch:more-diagnostic-items2, r=matthiaskrgr

    855395b

    Auto merge of #5509 - phansch:more-diagnostic-items2, r=matthiaskrgr

    1b7ed5c
  9. phansch
    added a commit that references this issue on Apr 26, 2020

    More diagnostic items

    0480ff8
  10. bors
    added 3 commits that reference this issue on Apr 26, 2020

    Auto merge of #5509 - phansch:more-diagnostic-items2, r=<try>

    ae0576a

    Auto merge of #5509 - phansch:more-diagnostic-items2, r=<try>

    90a9e88

    Auto merge of #5509 - phansch:more-diagnostic-items2, r=matthiaskrgr

    5c12f2b
  11. ThibsG
    added a commit that references this issue on May 2, 2020

    More diagnostic items

    69dad2d

  12. 36 remaining items

  13. Urgau
    added 2 commits that reference this issue on Feb 18, 2025

    Rollup merge of rust-lang#137214 - cyrgani:clippy_diagnostic_items, r…

    8b01e07

    Rollup merge of rust-lang#137214 - cyrgani:clippy_diagnostic_items, r…

    b7c2da2
  14. rust-timer
    added a commit that references this issue on Feb 18, 2025

    Unrolled build for rust-lang#137214

    166c28b
  15. github-actions
    added a commit that references this issue on Feb 19, 2025

    Rollup merge of #137214 - cyrgani:clippy_diagnostic_items, r=compiler…

    8f8a3a6
  16. github-actions
    added 2 commits that reference this issue on Mar 11, 2025

    Rollup merge of rust-lang#137214 - cyrgani:clippy_diagnostic_items, r…

    ed9315d

    Rollup merge of rust-lang#137214 - cyrgani:clippy_diagnostic_items, r…

    102e63b
  17. Alexendoo
    added
    G-performance-projectGoal: For issues and PRs related to the Clippy Performance Project
    on Apr 18, 2025

  18. samueltardieu commented on Jun 20, 2025

    @samueltardieu
    samueltardieu
    on Jun 20, 2025
    Member

    I think this issue can now be unpinned.

  19. samueltardieu
    unpinned this issue on Jun 20, 2025
  20. matthiaskrgr
    added a commit that references this issue on Jun 21, 2025

    Rollup merge of rust-lang#142787 - samueltardieu:diag-items-for-clipp…

    24f797e
  21. rust-timer
    added a commit that references this issue on Jun 21, 2025

    Unrolled build for #142787

    7a5dfbb

  22. samueltardieu commented on Jun 21, 2025

    @samueltardieu
    samueltardieu
    on Jun 21, 2025
    Member

    Fixed in r-l/r, will be imported during the next sync.

  23. samueltardieu
    closed this as completedon Jun 21, 2025
  24. flip1995
    added a commit that references this issue on Jun 26, 2025

    Rollup merge of #142787 - samueltardieu:diag-items-for-clippy, r=Mani…

    f027fc8
  25. tautschnig
    added a commit that references this issue on Jul 3, 2025

    Rollup merge of rust-lang#142787 - samueltardieu:diag-items-for-clipp…

    daf8ed1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-an-interesting-projectCategory: Interesting projects, that usually are more involved design/code wise.C-tracking-issueCategory: Tracking IssueE-mediumCall for participation: Medium difficulty level problem and requires some initial experience.G-performance-projectGoal: For issues and PRs related to the Clippy Performance Project

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions