"fuzz" clippy with official rustc tests #3142

Activity

1. oli-obk commented on Sep 7, 2018

   

   oli-obk

   on Sep 7, 2018

   Contributor

   More actions

   OH YES

   I want this very much. We want to do the same thing for miri, too. It should be rather simple to get done by setting https://github.com/rust-lang/rust/blob/master/src/tools/compiletest/src/common.rs#L134 to point to the clippy-driver binary.
2. oli-obk

   added

   C-an-interesting-projectCategory: Interesting projects, that usually are more involved design/code wise.Category: Interesting projects, that usually are more involved design/code wise.

   on Sep 7, 2018
3. matthiaskrgr commented on Sep 7, 2018

   

   matthiaskrgr

   on Sep 7, 2018

   Last edited by matthiaskrgr

   MemberAuthor

   More actions

   status:

   #!/bin/bash
   
   touch clippy.log
   for file in `find . | grep "\.rs$"`; do
   	echo ${file}
   	echo ${file} >> clippy.log
   	RUST_BACKTRACE=Full LD_LIBRARY_PATH=~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/ CLIPPY_TESTS=true  CARGO_MANIFEST_DIR="." ~/vcs/github/rust-clippy/target/debug/clippy-driver  -W clippy::all -W clippy::pedantic -W clippy::nursery ${file}  >> clippy.log 2>&1
   	rm -f `echo ${file} | sed "s@/@ @g" | awk 'NF>1{print $NF}' |   sed s/\.rs//`
   done;
4. matthiaskrgr commented on Oct 12, 2018

   

   matthiaskrgr

   on Oct 12, 2018

   Last edited by matthiaskrgr

   MemberAuthor

   More actions

   I hacked another small script that runs clippy on crates in the cargo cache

   #!/bin/bash
   
   for archive in `ls -c1 ~/.cargo/registry/cache/github.com-1ecc6299db9ec823/ | sort -n` ; do
   echo checking $archive
   mkdir /tmp/test_workdir
   cd ~/.cargo/registry/cache/github.com-1ecc6299db9ec823/
   cp ${archive} /tmp/test_workdir/
   cd /tmp/test_workdir
   #extract
   tar -xvzf ${archive} >& /dev/null
   cd ./*/
   
   CARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/tmp/CLIPPY_FUZZ_TARGET_DIR RUST_BACKTRACE=full cargo clippy --all-targets --all-features -vvvv -- --cap-lints warn -W clippy::internal -W clippy::pedantic -W clippy::nursery -W absolute-paths-not-starting-with-crate -W bare-trait-objects -W box-pointers -W elided-lifetimes-in-paths -Wellipsis-inclusive-range-patterns -W keyword-idents -W macro-use-extern-crate -W missing-copy-implementations  -W missing-debug-implementations -W missing-docs -W question-mark-macro-sep -W single-use-lifetimes -W trivial-casts -W trivial-numeric-casts -W unreachable-pub -W unsafe-code -W unstable-features -W unused-extern-crates -W unused-import-braces -W unused-labels -Wunused-lifetimes -Wunused-qualifications -Wunused-results -Wvariant-size-differences >& output.log
   if grep -q "internal compiler error\|query stack during panic" output.log ; then
   	echo ${archive} crashed!
   fi
   
   cd /tmp/
   
   rm -rf /tmp/test_workdir
   done
   

   🎉React with 🎉1Reacted by Philipp Krones
5. matthiaskrgr commented on Oct 16, 2018

   

   matthiaskrgr

   on Oct 16, 2018

   MemberAuthor

   More actions

   Ok cool, we can share build artifacts by using CARGO_TARGET_DIR so that clippy does not have to rebuilt deps for every single package from scratch! 🎉 this will speed up things a bit.
6. matthiaskrgr commented on Oct 17, 2018

   

   matthiaskrgr

   on Oct 17, 2018

   MemberAuthor

   More actions

   I found more crashes in

   metagoblin-0.0.1
   object-0.9.0
   quick-error-0.1.4
   scroll_derive-0.9.5
   

   but they seem rather similar, I'll revisit those once #3309 is fixed

   🎉React with 🎉1Reacted by Phil Hansch
7. matthiaskrgr commented on Oct 17, 2018

   

   matthiaskrgr

   on Oct 17, 2018

   MemberAuthor

   More actions

   Looks all 4 were related :)
8. matthiaskrgr commented on Oct 24, 2018

   

   matthiaskrgr

   on Oct 24, 2018

   MemberAuthor

   More actions

   I made the bash script into a small rust crate that runs clippy on crates in the local cargo cache.
   https://github.com/matthiaskrgr/clippy_crashfinder/blob/master/src/main.rs
9. matthiaskrgr commented on Jan 8, 2022

   

   matthiaskrgr

   on Jan 8, 2022

   MemberAuthor

   More actions

   Ah I didn't know we still had this open :)

   I have since written my own little crashfinder which has found close to 100 rustc crashes and of course it also has a clippy mode :) icemaker -c

   https://github.com/matthiaskrgr/icemaker

   👍React with 👍3Reacted by Fridtjof Stoldt, oli and llogiq
10. matthiaskrgr commented on Dec 13, 2023

    

    matthiaskrgr

    on Dec 13, 2023

    MemberAuthor

    More actions

    To give another update, I've been running clippy on several tens of gigabyte of fuzzed code (based on rustc testsuite) now without finding any noteworthy ICEs iirc. :)

    👍React with 👍1Reacted by Samuel Tardieu
11. xFrednet commented on Dec 17, 2023

    

    xFrednet

    on Dec 17, 2023

    Contributor

    More actions

    Awesome! Have you continues using the /icemaker repo you linked? I might be interested to see how Marker handles everything (I still expect a lot of crashes 😅 )