Repository navigation
fix nightly warning legacy_derive_helpers - #7648
Merged
Merged
Conversation
Member
|
Thanks! It looks good, but we have some CI issues that aren't related to your change. |
Contributor
|
bors r+ |
bors Bot
added a commit
that referenced
this pull request
Feb 12, 2021
7644: Primitive completion r=jonas-schievink a=jonas-schievink Fixes #7642 7648: fix nightly warning `legacy_derive_helpers` r=jonas-schievink a=peddermaster2 With a recent nightly (e.g. 2021-02-10) a warning comes up. This PR reorders the attributes to fix the warning. See rust-lang/rust#79202 Co-authored-by: Jonas Schievink <jonasschievink@gmail.com> Co-authored-by: Peter Wischer <peter.wischer@lwl.org>
Contributor
|
Build failed (retrying...): |
bors Bot
added a commit
that referenced
this pull request
Feb 12, 2021
7648: fix nightly warning `legacy_derive_helpers` r=jonas-schievink a=peddermaster2 With a recent nightly (e.g. 2021-02-10) a warning comes up. This PR reorders the attributes to fix the warning. See rust-lang/rust#79202 Co-authored-by: Peter Wischer <peter.wischer@lwl.org>
Contributor
|
Build failed: |
Member
|
Ugh. Can you update the hash in |
peddermaster2
force-pushed
the
fix-procmacro-ordering
branch
from
February 12, 2021 12:46
23bf030 to
908ca40
Compare
Author
|
Done. |
Member
|
bors r+ |
peddermaster2
force-pushed
the
fix-procmacro-ordering
branch
from
February 12, 2021 12:58
908ca40 to
f18fc5a
Compare
Contributor
|
Canceled. |
Member
|
bors r+ There was no need to rebase. |
Author
|
It was getting the same errors with the formatting as before. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a recent nightly (e.g. 2021-02-10) a warning comes up. This PR reorders the attributes to fix the warning.
See rust-lang/rust#79202