Skip to content

Tweak message shown for query fallback - #522

Merged
bors[bot] merged 1 commit into
rust-lang:masterfrom
killercup:smol-err-msg-fix
Jan 13, 2019
Merged

bors[bot] merged 1 commit into
rust-lang:masterfrom
killercup:smol-err-msg-fix

Conversation

@killercup

Copy link
Copy Markdown
Contributor

Small tweak for #518

@killercup

Copy link
Copy Markdown
Contributor Author

Originally noticed this because of:

bildschirmfoto 2019-01-13 um 13 27 27

It now only shows the second line of there are methods items to show.


I assume that Arc doesn't resolve in this snippet is a known bug:

use std::sync::{Arc, Mutex};

/// Structure holding your output targets
#[derive(Default, Clone)]
pub struct Output {
    inner: Arc<Mutex<InnerOutput>>,
}

but I can quickly open an issue if necessary

@DJMcNab

DJMcNab commented Jan 13, 2019

Copy link
Copy Markdown
Contributor

bors r+

Thanks! That's definitely a better user experience.

bors Bot added a commit that referenced this pull request Jan 13, 2019
522: Tweak message shown for query fallback r=DJMcNab a=killercup

Small tweak for #518

Co-authored-by: Pascal Hertleif <killercup@gmail.com>
@flodiebold

flodiebold commented Jan 13, 2019 •

Copy link
Copy Markdown
Member

Hm. About Arc, std::sync gets properly resolved, but it reexports Arc from alloc_crate, which is an extern crate rename: extern crate alloc as alloc_crate. I guess that's the problem. I don't think we have an explicit bug for this...

@bors

bors Bot commented Jan 13, 2019

Copy link
Copy Markdown
Contributor

Build succeeded

@bors
bors Bot merged commit 7f16f92 into rust-lang:master Jan 13, 2019
@killercup

Copy link
Copy Markdown
Contributor Author

Thanks for the quick merge! @flodiebold alright, I'll open an issue with a reproducible test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants