Repository navigation
Get the test suite working inside the rustc test suite - #300
Merged
Merged
Conversation
Member
|
What exactly is it that used to not work and works with this? I don't understand what "inside the rustc test suite" means. |
Member
|
Ah, I see. This is for rust-lang/rust#43628. Looks good! |
RalfJung
approved these changes
Aug 10, 2017
Member
|
Of course, eventually, we will want to run miri on the entire rustc testsuite itself, not just on in its rather small testsuite. :) |
Contributor
Author
for that we need a way to mark tests as "miri will always fail on this" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to weave some env vars over from rustc, but it works now both within rustc and here.