Skip to content

Support floating point types f32 and f64 #35

Closed

Description

@gnzlbg

Support floating point types. Probably have to add both f32, and f64 to PrimVal, and handle those everywhere.

AFAIK Rust floating point arithmetic follows IEEE754. Still, I don't know what happens on architectures that do not fully conform to the spec. Does Rust or LLVM emulate it or not? Probably not. This might turn out to not be a problem in practice (e.g. miri result would still be deterministic "enough of the time"). Once we are the we might want to reconsider that though.

Activity

  1. added
    C-enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancement
    on Jun 22, 2016
  2. solson commented on Jul 7, 2016

    @solson
    Contributor

    I merged @oli-obk's host-architecture floats, which I think is fine for now. If we later find that not matching target behaviour is a problem in practice, we can revisit this issue.

  3. added a commit that references this issue on Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions