Repository navigation
Add FRAC_1_SQRT_2PI constant #383
Description
Proposal
Problem statement
Statistical calculations, image and signal processing applications commonly need to calculate a scaling factor of 1/√(2π) for the Gaussian probability distribution (specifically, 1/(σ√(2π)) where sigma is application specific).
The standard normal distribution is the same with trivially σ=1 (and x=y):
With the current constants, the calculation of the scaling term requires
FRAC_1_SQRT_PI * FRAC_1_SQRT_2 / sigmaI propose to add FRAC_1_SQRT_2PI (as 1/√(2π)) in order to simplify this to
FRAC_1_SQRT_2PI / sigmareducing clutter and keeping mathematical precision.
This would go in line with #103883 and rust-lang/rust#123850 which add the FRAC_1_SQRT_PI constant (1/√π).
Motivating examples or use cases
The image processing library imgproc uses this code for calculating a blur filter:
/// The gaussian probability density function with a mean of zero.
#[inline]
fn gaussian_pdf(x: f32, sigma: f32) -> f32 {
// Equation derived from <https://en.wikipedia.org/wiki/Gaussian_function>
(sigma * (2.0 * f32::consts::PI).sqrt()).recip() * (-x.powi(2) / (2.0 * sigma.powi(2))).exp()
}This example is less about the choice of a functional implementation style, but it showcases the need for this particular calculation. (Do note that since this is an image processing application, the parameter sigma must be freely settable and at least parts of the scaling term must be determined ad-hoc.)
The Normal Distribution (Gaussian PDF), Bayesian Statistics as a whole, Error Function calculation and Fourier Transformations are all centered around the same fundamental calculation.
In financial applications, the Black-Scholes model comes up. As an example, the black_scholes_rust crate implements it like this.
fn inc_norm(x: f64) -> f64 {
(-x.powi(2) / 2.0).exp() / (PI.sqrt() * SQRT_2)
}In physics, the Maxwell-Boltzmann equation has the term as .powf(1.5)).
Solution sketch
Trivially, adding FRAC_1_SQRT_2PI as 1/√(2π) = 0.3989422804014326779399460599343818684758586311649346576659258296… (from here). I went ahead and drafted it in rust-lang/rust#125253.
Alternatives
A combination of FRAC_1_SQRT_PI and FRAC_1_SQRT_2 can be used, however at more visual clutter. Applications can make use of const evaluation and reuse their own constant, but this may be subject to floating point processing on the individual machine (arguably; I did not analyze the error potential here).
In some cases (e.g. signal processing) the entire calculation can be done "on paper", e.g. when the standard deviation parameter sigma will never change in signal processing applications or image filtering.
Bivariate normal distributions do not have this problem, so this focuses on the most common Gaussians.
Links and related work
Implementation of the above:
Related proposals:
Previous work on constants:
What happens now?
This issue contains an API change proposal (or ACP) and is part of the libs-api team feature lifecycle. Once this issue is filed, the libs-api team will review open proposals as capability becomes available. Current response times do not have a clear estimate, but may be up to several months.
Possible responses
The libs team may respond in various different ways. First, the team will consider the problem (this doesn't require any concrete solution or alternatives to have been proposed):
- We think this problem seems worth solving, and the standard library might be the right place to solve it.
- We think that this probably doesn't belong in the standard library.
Second, if there's a concrete solution:
- We think this specific solution looks roughly right, approved, you or someone else should implement this. (Further review will still happen on the subsequent implementation PR.)
- We're not sure this is the right solution, and the alternatives or other materials don't give us enough information to be sure about that. Here are some questions we have that aren't answered, or rough ideas about alternatives we'd want to see discussed.
Activity
the8472 commentedon May 26, 2024
I'm wondering if it'd be possible have some macro that evaluates things infinite precision and spits out a float constant. E.g.
fconst!(1 / sqrt(2 * PI), f32).kennytm commentedon May 26, 2024
@the8472 you don't need infinite precision, doing the computation in a higher precision than
f32/f64/f128should be enough.But please don't make
fconst!a compiler or std feature, there is no point bringing in e.g. internalf256support for everyone, just to let some users be able to define arbitrary mathematical constants. They can easily be calculated properly outside the compiler.clarfonthey commentedon May 27, 2024
I'm fine with this constant, although the hill I will die on (for my corpse to rot away and be ignored) is that it should be
FRAC_1_SQRT_TAUfor consistency with the existingTAUconstant.I mean this in the sense of, I would like this change in naming, but absolutely will not block it over this.
sunsided commentedon May 27, 2024
@clarfonthey I see your point. What's your take on (renaming and) adding
#[doc(alias = "FRAC_1_SQRT_2PI")]?kennytm commentedon May 27, 2024
One big reason why$\pi/2$ ), and
TAUwas adapted (aside from the tau-manifesto) is that2PIis not a valid identifier,PI_2is wrong (easily mistaken asTWO_PIis very ugly. There is also a precedence from Python. These all do not matter forFRAC_1_SQRT_2PI.And practically everyone used$1/\sqrt{2\pi}$ rather than $1/\sqrt\tau$ . So I think making
FRAC_1_SQRT_TAUthe canonical name will hurt its discoverability.joshtriplett commentedon May 28, 2024
(Speaking for myself here.)
FRAC_1_SQRT_2PIseems like the right naming here. Most people still use pi, and an alias seems suboptimal. By all means add an alias for theTAUversion.joshtriplett commentedon May 28, 2024
We discussed this in today's @rust-lang/libs-api meeting. We observed that this constant doesn't currently exist among C's constants, but we were still sympathetic to adding this. We're inclined to add this, but we'd like a second opinion.
I think @m-ou-se has worked with the C constants before. Do you have an opinion on this?
quaternic commentedon Jun 7, 2024
Two existing alternatives:
All of
*, /, sqrtshould be correctly rounded (so there should be no machine dependence), and for the above expressions (for both f32 and f64), those match the result without intermediate rounding. https://rust.godbolt.org/z/KaPGvvx9WThat's partially by chance, since for different real values
1 / sqrt(x)(as computed in f32) can be off by up to 2ULP (from the exact result rounded to f32).In principle, I'm mildly against adding more constants that are just simple expressions, since it clutters (even if only slightly) the library and only helps the cases that need that specific constant. Once you want to further map that constant, the benefit over just writing the expression mostly disappears. We have a language for composing expressions already, so I'd rather see and work with something like
math!(1 / sqrt(2 * PI)) as f32than parse and distinguish betweenFRAC_1_SQRT_2PI,FRAC_2_SQRT_PI, orFRAC_1_SQRT_PI.joshtriplett commentedon Apr 29, 2025
Pinging @m-ou-se for follow-up here, to get a second opinion about adding this.
m-ou-se commentedon Apr 30, 2025
I think it's fine to add this.
While I'm a big Tau fan (and the person who added
TAUto Rust), I agree using2PIin the name makes more sense. If we ever get to a point in time where more people are using τ than 2π in practice, we can consider adding another constant. I don't think that will happen any time soon, unfortunately.Note that rust-lang/rust#125253 has already been merged, so it's already available as unstable. Are we discussing stabilizing this now? Or should this issue be closed?
programmerjake commentedon Apr 30, 2025
imo if we're adding
FRAC_1_SQRT_2PIwe should also addFRAC_1_SQRT_TAUAmanieu commentedon May 6, 2025
We discussed this in the @rust-lang/libs-api meeting and would like to accept this under the name
FRAC_1_SQRT_2PIonly.Please open a tracking issue and open a PR to rust-lang/rust to add it as an unstable feature. You can close this ACP once the tracking issue has been created.
kennytm commentedon May 6, 2025
it is already merged into libcore and tracked under rust-lang/rust#103883 (comment).
m-ou-se commentedon May 6, 2025
Looks like we should just close it, now that we've confirmed we agree with the name
FRAC_1_SQRT_2PI:)