Skip to content

Version 0.2.63 breaks on musl #1483

Closed
Closed

Description

@DianaNites

The latest update fails to compile when using musl targets. Minimum example.

use libc::ENETUNREACH;

fn main() {}

Fails with cargo check --target=x86_64-unknown-linux-musl on 0.2.63. Works on 0.2.62. Works on gnu targets.

Stable rust, 1.37.0

Seems to be for all errno constants? Thats whats failing at least.

error[E0425]: cannot find value `ENETUNREACH` in module `libc`
   --> /home/diana/.local/share/cargo/registry/src/github.com-1ecc6299db9ec823/nix-0.15.0/src/errno.rs:682:33
    |
682 |         ENETUNREACH     = libc::ENETUNREACH,
    |                                 ^^^^^^^^^^^ not found in `libc`
help: possible candidate is found in another module, you can import it into scope
    |
578 |     use errno::consts::Errno::ENETUNREACH;
    |

Activity

  1. gnzlbg commented on Aug 20, 2019

    @gnzlbg
    Contributor

    Thanks for the report.

  2. jbg commented on Aug 20, 2019

    @jbg

    Getting a similar compilation failure on musl here, but with EINPROGRESS.

       Compiling socket2 v0.3.11
    error[E0425]: cannot find value `EINPROGRESS` in crate `libc`
       --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/socket2-0.3.11/src/sys/unix.rs:141:58
        |
    141 |             Err(ref e) if e.raw_os_error() == Some(libc::EINPROGRESS) => {}
        |                                                          ^^^^^^^^^^^ not found in `libc`
    
  3. gnzlbg commented on Aug 20, 2019

    @gnzlbg
    Contributor

    Offending commit: 9df2deb

    This should have been caught by our semver tests, but we disabled them when migrating to Azure pipelines (cc @pietroalbini - any updates on allowing tests to fail? That's what's blocking re-adding these tests).

  4. emilyalbini commented on Aug 20, 2019

    @emilyalbini
    Member

    any updates on allowing tests to fail? That's what's blocking re-adding these tests

    You should be able to add continueOnError on a job. Docs

  5. gnzlbg commented on Aug 20, 2019

    @gnzlbg
    Contributor

    PR with a fix #1484

  6. gnzlbg commented on Aug 20, 2019

    @gnzlbg
    Contributor

    I've yanked 0.2.63, @DianaNites @jbg a cargo update should hopefully revert your projects back to 0.2.62 which doesn't have the issue. Can you confirm that that works? (EDIT: on CI, retrying should pick 0.2.62 as well).

  7. jbg commented on Aug 20, 2019

    @jbg

    Works here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions