Skip to content

Need a x32 stack probing function  #282

Closed

Description

@crlf0710

According to rust-lang/rust#59674, such a function is needed to re-enable stack probing on gnux32 in src/probestack.rs.

Activity

  1. nikic commented on Jul 24, 2019

    @nikic
    Contributor

    x32 stack probing is now reenabled using the probing function for x86_64. I don't think a separate one is needed.

  2. crlf0710 commented on Jul 24, 2019

    @crlf0710
    MemberAuthor

    Yeah, just need to wait for rust-lang/rust#62808 to land, then we can close this.

  3. nikic commented on Jul 24, 2019

    @nikic
    Contributor

    Oh sorry, I thought that had already landed after seeing the "merged" message ... but apparently that didn't actually happen.

  4. bjorn3 commented on Jul 24, 2019

    @bjorn3
    Member

    Actually it is merged into master:

    afbeelding

  5. nikic commented on Jul 25, 2019

    @nikic
    Contributor

    I've manually closed that PR now and it properly went into "merged" state. Github just went a bit crazy...

  6. crlf0710 commented on Jul 26, 2019

    @crlf0710
    MemberAuthor

    ok, then let's close this too.

  7. added a commit that references this issue on Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions