Skip to content

refactor(config): Consolidate more config table definitions - #17480

Merged
rustbot merged 9 commits into
rust-lang:masterfrom
epage:schema
Sep 16, 2026
Merged

rustbot merged 9 commits into
rust-lang:masterfrom
epage:schema

Conversation

@epage

@epage epage commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR try to resolve?

Just another small step towards #12883

The only thing left afaik is [unstable] which may not be worth pulling out.

How to test and review this PR?

LLM Disclosure: Used it for "trivial" purpose of moving structs so imports would be updated. Manually inspected doc comments to ensure they did not get changed in the process

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. A-configuration Area: cargo config files and env vars Command-new S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2026
@rustbot

rustbot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Muscraft, @epage, @weihanglo
  • @Muscraft, @epage, @weihanglo expanded to Muscraft, epage, weihanglo
  • Random selection from Muscraft, weihanglo

@weihanglo

Copy link
Copy Markdown
Member

The only thing left afaik is [unstable] which may not be worth pulling out.

Not sure what you meant by this, but there are other configs still scattering, like install.root, doc.browser, credential-alias, target.*.rustflags, and target.*.links.

@weihanglo weihanglo left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, looks good!

@rustbot merge

View changes since this review

@rustbot
rustbot enabled auto-merge September 16, 2026 01:34
@rustbot
rustbot added this pull request to the merge queue Sep 16, 2026
Merged via the queue into rust-lang:master with commit f325466 Sep 16, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2026
@epage
epage deleted the schema branch September 16, 2026 13:04
@epage

epage commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

The only thing left afaik is [unstable] which may not be worth pulling out.

Not sure what you meant by this, but there are other configs still scattering, like install.root, doc.browser, credential-alias, target.*.rustflags, and target.*.links.

Oops, I meant that I was aware of atm

rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Sep 16, 2026
Update cargo submodule

9 commits in 7941be6fb416b4cd9666aef7b858dfea25587a8c..495c385d0875c4ba51eb72ea0448a2d4c018b8d4
2026-09-11 20:47:37 +0000 to 2026-09-16 12:48:58 +0000
- Report the number of errors with `build.warnings='deny'` (rust-lang/cargo#17479)
- fix: return correct package specs when resolving workspace deps (rust-lang/cargo#17469)
- refactor(config): Consolidate more config table definitions (rust-lang/cargo#17480)
- fix(git): For git cli, tell users what config we aren't forwarding on error (rust-lang/cargo#17477)
- Lower the lint level of `manual_readme` and `non_kebab_case_bins` to `allow` (rust-lang/cargo#17478)
- fix(trim-paths)!: unremap file in one JSON doc (rust-lang/cargo#17476)
- feat(manifest): support `feature-documentation` in manifests (rust-lang/cargo#17447)
- chore: Add Muscraft to the review rotation (rust-lang/cargo#17471)
- Specify `--edition` in `messages` tests (rust-lang/cargo#17470)

r? Urgau 
for the debugger script part

---

🤖 LLM disclosure: I probably should have tested this change manually, though I let LLM verify it working, sorry. Will do a manual test when I have time or if somebody beats me on that.
@rustbot rustbot added this to the 1.100.0 milestone Sep 16, 2026
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Sep 17, 2026
Update cargo submodule

9 commits in 7941be6fb416b4cd9666aef7b858dfea25587a8c..495c385d0875c4ba51eb72ea0448a2d4c018b8d4
2026-09-11 20:47:37 +0000 to 2026-09-16 12:48:58 +0000
- Report the number of errors with `build.warnings='deny'` (rust-lang/cargo#17479)
- fix: return correct package specs when resolving workspace deps (rust-lang/cargo#17469)
- refactor(config): Consolidate more config table definitions (rust-lang/cargo#17480)
- fix(git): For git cli, tell users what config we aren't forwarding on error (rust-lang/cargo#17477)
- Lower the lint level of `manual_readme` and `non_kebab_case_bins` to `allow` (rust-lang/cargo#17478)
- fix(trim-paths)!: unremap file in one JSON doc (rust-lang/cargo#17476)
- feat(manifest): support `feature-documentation` in manifests (rust-lang/cargo#17447)
- chore: Add Muscraft to the review rotation (rust-lang/cargo#17471)
- Specify `--edition` in `messages` tests (rust-lang/cargo#17470)

r? Urgau 
for the debugger script part

---

🤖 LLM disclosure: I probably should have tested this change manually, though I let LLM verify it working, sorry. Will do a manual test when I have time or if somebody beats me on that.
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Sep 17, 2026
Update cargo submodule

9 commits in 7941be6fb416b4cd9666aef7b858dfea25587a8c..495c385d0875c4ba51eb72ea0448a2d4c018b8d4
2026-09-11 20:47:37 +0000 to 2026-09-16 12:48:58 +0000
- Report the number of errors with `build.warnings='deny'` (rust-lang/cargo#17479)
- fix: return correct package specs when resolving workspace deps (rust-lang/cargo#17469)
- refactor(config): Consolidate more config table definitions (rust-lang/cargo#17480)
- fix(git): For git cli, tell users what config we aren't forwarding on error (rust-lang/cargo#17477)
- Lower the lint level of `manual_readme` and `non_kebab_case_bins` to `allow` (rust-lang/cargo#17478)
- fix(trim-paths)!: unremap file in one JSON doc (rust-lang/cargo#17476)
- feat(manifest): support `feature-documentation` in manifests (rust-lang/cargo#17447)
- chore: Add Muscraft to the review rotation (rust-lang/cargo#17471)
- Specify `--edition` in `messages` tests (rust-lang/cargo#17470)

r? Urgau 
for the debugger script part

---

🤖 LLM disclosure: I probably should have tested this change manually, though I let LLM verify it working, sorry. Will do a manual test when I have time or if somebody beats me on that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area: Command-line interface, option parsing, etc. A-configuration Area: cargo config files and env vars Command-new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants