Repository navigation
fix(publish): deprecate CLI token - #15994
Closed
omskscream wants to merge 2 commits into
Closed
omskscream wants to merge 2 commits into
omskscream wants to merge 2 commits into
Conversation
Came up in rust-lang#15274 to avoid putting tokens into a shell history for `publish` command as well as login.
Collaborator
remove deprecated `--token` option from docs
omskscream
force-pushed
the
publish-warn-token
branch
from
September 21, 2025 18:58
fa7eb9c to
88828ea
Compare
Contributor
|
There are two changes here
Ideally this would be structured as at least two commits. More likely, these should be separate PRs to get the appropriate level of attention to each. |
Contributor
Author
|
Thanks for the comment! Valid point, I thought about separate PRs too. I'll close this one and will recreate changes in separate pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Came up in #15274 to avoid putting tokens into a shell history for
publishcommand.Implemented similar to #15057
This PR deprecates the optional argument in
cargo publish, meaning: