Skip to content

0.43.0 published with wrong version #7994

Closed

Description

@ehuss

Problem
It looks like 0.43.0 was published with the wrong version. rust 1.42.0 was published with 8633429 (seen at https://github.com/rust-lang/rust/tree/1.42.0/src/tools or running cargo -V). However, it looks like 0.43.0 was tagged with 9d32b7b (0.43.0), missing #7848, and the version on crates.io is also the older commit.

I'm not sure what the best solution is. Maybe publish 0.43.1 with the fix?

Notes
@pietroalbini is there something we can do to improve the release process to avoid problems like these? This happened recently (#7503), and I'd like to try to avoid it happening again. I'm not familiar with your process, but if it is automated perhaps there's something that needs to be fixed?

Activity

  1. emilyalbini commented on Mar 13, 2020

    @emilyalbini
    Member

    I'm not sure what the best solution is. Maybe publish 0.43.1 with the fix?

    @Mark-Simulacrum what do we want to do?

    I'm not familiar with your process, but if it is automated perhaps there's something that needs to be fixed?

    I'm mostly doing stuff manually, which is probably the cause of my occasional errors :(

  2. Mark-Simulacrum commented on Mar 13, 2020

    @Mark-Simulacrum
    Member

    I think we should yank what we've published and publish 0.43.1 (with the correct version).

    I think we should also work on automating the release process in general; this step at least seems like it could plausibly happen entirely automatically. Testing that automation may be a bit painful, but maybe we can publish to a staging version of crates.io?

    I should be able to find the time to work on such automation in the next 6 weeks. In theory it should just be built-in to our normal release process I think.

  3. added a commit that references this issue on Mar 17, 2020
  4. ehuss commented on Mar 17, 2020

    @ehuss
    ContributorAuthor

    I have bumped the version to 0.43.1 on the rust-1.42.0 branch. If someone with permission could re-publish cargo, this can be closed (make sure it is revision 5b129c4).

  5. emilyalbini commented on Mar 17, 2020

    @emilyalbini
    Member

    Published!

  6. ehuss commented on Mar 17, 2020

    @ehuss
    ContributorAuthor

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions