You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem
It looks like 0.43.0 was published with the wrong version. rust 1.42.0 was published with 8633429 (seen at https://github.com/rust-lang/rust/tree/1.42.0/src/tools or running cargo -V). However, it looks like 0.43.0 was tagged with 9d32b7b (0.43.0), missing #7848, and the version on crates.io is also the older commit.
I'm not sure what the best solution is. Maybe publish 0.43.1 with the fix?
Notes @pietroalbini is there something we can do to improve the release process to avoid problems like these? This happened recently (#7503), and I'd like to try to avoid it happening again. I'm not familiar with your process, but if it is automated perhaps there's something that needs to be fixed?
I think we should yank what we've published and publish 0.43.1 (with the correct version).
I think we should also work on automating the release process in general; this step at least seems like it could plausibly happen entirely automatically. Testing that automation may be a bit painful, but maybe we can publish to a staging version of crates.io?
I should be able to find the time to work on such automation in the next 6 weeks. In theory it should just be built-in to our normal release process I think.
I have bumped the version to 0.43.1 on the rust-1.42.0 branch. If someone with permission could re-publish cargo, this can be closed (make sure it is revision 5b129c4).
Activity
emilyalbini commentedon Mar 13, 2020
@Mark-Simulacrum what do we want to do?
I'm mostly doing stuff manually, which is probably the cause of my occasional errors :(
Mark-Simulacrum commentedon Mar 13, 2020
I think we should yank what we've published and publish 0.43.1 (with the correct version).
I think we should also work on automating the release process in general; this step at least seems like it could plausibly happen entirely automatically. Testing that automation may be a bit painful, but maybe we can publish to a staging version of crates.io?
I should be able to find the time to work on such automation in the next 6 weeks. In theory it should just be built-in to our normal release process I think.
Auto merge of #8004 - ehuss:1.42-bump, r=alexcrichton
ehuss commentedon Mar 17, 2020
I have bumped the version to 0.43.1 on the rust-1.42.0 branch. If someone with permission could re-publish cargo, this can be closed (make sure it is revision 5b129c4).
emilyalbini commentedon Mar 17, 2020
Published!
ehuss commentedon Mar 17, 2020
Thanks!