Skip to content

Tracking issue for config-cli #7722

Closed
#10755
Closed
Tracking issue for config-cli#7722
#10755
Labels
A-config-cliArea: --config CLI optionC-tracking-issueCategory: A tracking issue for something unstable.T-cargoTeam: Cargodisposition-mergeFCP with intent to mergefinished-final-comment-periodFCP complete

Description

@ehuss
ehuss
opened on Dec 19, 2019

Implementation: #7649
Original proposal: #6699
Documentation: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#config-cli

Summary

Adds --config CLI option to pass config options to any command.

Unresolved issues

Activity

  1. ehuss
    added
    C-tracking-issueCategory: A tracking issue for something unstable.
    A-config-cliArea: --config CLI option
    on Dec 19, 2019
  2. bors
    added a commit that references this issue on Feb 18, 2020

    Auto merge of #7901 - ehuss:config-cli-path, r=alexcrichton

    e0678fb

  3. jyn514 commented on Sep 19, 2020

    @jyn514
    jyn514
    on Sep 19, 2020
    Member

    A use case for this: docs.rs wants to pass RUSTFLAGS without having the spacing interpreted by the shell: rust-lang/docs.rs#1057

  4. Nemo157 commented on Dec 1, 2020

    @Nemo157
    Nemo157
    on Dec 1, 2020
    Contributor

    Is it not possible to specify registry sources via this? I wanted to migrate from using registry-index sources in Publishing crates to IPFS so that I could test it with #8890, but trying to use this flag to define the registries it doesn't seem to be picked up:

    > cargo -Zunstable-options '--config=source.bs58_cli_0_1_0_anyhow.registry="http://127.0.0.1:8080/ifps/QmP6KmpjQrYpYyeXGqAvmrw45dPoKvmKeTqTanmSqJGJKz"' '--config=source.bs58_cli_0_1_0_bs58.registry="http://127.0.0.1:8080/ifps/Qmb2PJ9vMALRFmQjLDQbcNHYUvcFc96XzKMwAhBMEECxzb"' '--config=source.bs58_cli_0_1_0_paw.registry="http://127.0.0.1:8080/ifps/QmNkJbrmpjJErbX9fTpSSQYb7Ky1Qnpg47QptfMcVQUwBx"' '--config=source.bs58_cli_0_1_0_structopt.registry="http://127.0.0.1:8080/ifps/Qmbh5sZbKezvYq2ESVhbnymqs7VKMTaz7yXUaoMi9tBjJp"' update --manifest-path /tmp/ipfs-registry.bs58-cli-0.1.0.yIgXKp/bs58-cli-0.1.0/Cargo.toml
error: failed to parse manifest at `/tmp/ipfs-registry.bs58-cli-0.1.0.yIgXKp/bs58-cli-0.1.0/Cargo.toml`

Caused by:
  no index found for registry: `bs58_cli_0_1_0_anyhow`

  5. Nemo157 commented on Dec 1, 2020

    @Nemo157
    Nemo157
    on Dec 1, 2020
    Contributor

    🤦 ignore that, I was using the wrong config key.

  6. dancrossnyc commented on Jul 1, 2021

    @dancrossnyc
    dancrossnyc
    on Jul 1, 2021

    Curious if there's any updated status on this? It would be really great to get stabilized!

  7. ehuss commented on Jul 1, 2021

    @ehuss
    ehuss
    on Jul 1, 2021
    ContributorAuthor

    There's no update. There's still an unresolved issue noted above that needs someone to work on it.

  8. jonhoo commented on Nov 23, 2021

    @jonhoo
    jonhoo
    on Nov 23, 2021
    Contributor

    I'll add what I think is a pretty compelling use-case for this: passing -Zinstrument-coverage for coverage testing (which is stabilizing in rust-lang/rust#90132). It requires leaving any existing rustflags intact since things like linker flags (-Clink-args) may be required for the crate to build in the first place, which using RUSTFLAGS doesn't do (#5376) but --config='build.rustflags = ["-Zinstrument-coverage"]' does (#5376 (comment)).

    For the unresolved issue, some guidance on exactly what you're imagining would be helpful @ehuss. Specifically, why do you think that restriction is necessary in the first place? Alternatively, could we just parse into a toml::Value and then check that it only contains one actual entry?

  9. ehuss commented on Nov 29, 2021

    @ehuss
    ehuss
    on Nov 29, 2021
    ContributorAuthor

    The restriction is to just constrain the format so that it has a straightforward syntax. That way, someone wouldn't be able to pass in comments or [bracketed.tables] or newlines or anything like that. It already parses to a toml::Value and checks for one value.

  10. jonhoo commented on Dec 6, 2021

    @jonhoo
    jonhoo
    on Dec 6, 2021
    Contributor

    👍
    Implemented in #10176

  11. jonhoo
    added a commit that references this issue on Dec 6, 2021

    Check --config for dotted keys only

    80fbfed
  12. bors
    added a commit that references this issue on Jan 25, 2022

    Auto merge of #10176 - jonhoo:config-cli-simple, r=ehuss

    018acfd

  13. jonhoo commented on Jan 25, 2022

    @jonhoo
    jonhoo
    on Jan 25, 2022
    Contributor

    Now that #10176 has been merged, I think the unchecked box can be ticked!

  14. 40 remaining items

  15. bors
    added a commit that references this issue on Jun 22, 2022

    Auto merge of #10755 - jonhoo:stabilize-config-cli, r=ehuss

    ed549d8
  16. bors
    closed this as completedin 39c3173on Jun 22, 2022
  17. Hezuikn
    added 6 commits that reference this issue on Sep 22, 2022

    Disallow setting registry tokens with --config

    58a672e

    Allow --config path without config-include

    1f11a51

    Stabilize --config

    f994139

    Disallow setting registry tokens with --config

    9190906

    Allow --config path without config-include

    693412b

    Stabilize --config

    a3e3df0
  18. epage
    added this to Cargo Roadmapon Sep 5, 2023
  19. epage
    moved this to Done in Cargo Roadmapon Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-config-cliArea: --config CLI optionC-tracking-issueCategory: A tracking issue for something unstable.T-cargoTeam: Cargodisposition-mergeFCP with intent to mergefinished-final-comment-periodFCP complete

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions