Skip to content

Cargo should strip features of dev dependencies #12225

Closed
#13518
Closed
Cargo should strip features of dev dependencies#12225
#13518
Assignees
linyihai
Labels
C-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Command-publishS-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or review

Description

@Morganamilo
Morganamilo
opened on Jun 2, 2023

Problem

#7333 added stripping of dependencies, but did not strip features pointing to those dependencies.

This causes a rather unintuitive error where cargo says the dependency does not exist. Which one would only understand if they knew about the stripping that cargo does.

Proposed Solution

Cargo should also strip these features from the manifest before publishing.

If foo is a dev-dependency being stripping then a = ["foo/a"] should be transformed to a = [].

Notes

No response

Activity

  1. Morganamilo
    added
    C-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
    S-triageStatus: This issue is waiting on initial triage.
    on Jun 2, 2023
  2. ehuss
    added
    Command-publish
    S-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or review
    and removed
    S-triageStatus: This issue is waiting on initial triage.
    on Jun 2, 2023

  3. eval-exec commented on Jun 4, 2023

    @eval-exec
    eval-exec
    on Jun 4, 2023
    Contributor

    @rustbot claim

  4. rustbot
    assigned
    eval-exec
    on Jun 4, 2023

  5. eval-exec commented on Jun 4, 2023

    @eval-exec
    eval-exec
    on Jun 4, 2023
    Contributor

    Hello, I submitted a PR to fix this。 Would you like review my PR and provide your feedback? 💟

  6. ehuss
    unassigned
    eval-exec
    on Dec 4, 2023
  7. phil-opp
    added a commit that references this issue on Dec 27, 2023

    Fix: Enable test runner again

    7b018e2

  8. linyihai commented on Feb 21, 2024

    @linyihai
    linyihai
    on Feb 21, 2024
    Contributor

    @rustbot claim

    I'm going to try, and if I haven't moved for a long time, feel free to pick it up and continue.

  9. rustbot
    assigned
    linyihai
    on Feb 21, 2024
  10. bors
    added a commit that references this issue on Mar 14, 2024

    Auto merge of #13518 - baby230211:fix/strip-feature-dev-dep, r=epage

    403fbe2
  11. bors
    closed this as completedin 403fbe2on Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Command-publishS-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions