Skip to content

use cfg_select instead of cfg_if - #763

Open
hkBst wants to merge 2 commits into
rust-lang:mainfrom
hkBst:cfg-select
Open

hkBst wants to merge 2 commits into
rust-lang:mainfrom
hkBst:cfg-select

Conversation

@hkBst

@hkBst hkBst commented Jul 2, 2026

Copy link
Copy Markdown
Member

Now that cfg_select is stable since 1.95, we can replace cfg_if. One difference is that cfg_select needs one branch to match. Therefore an empty default branch is sometimes needed.

Comment thread src/symbolize/gimli.rs
// Everything else should doesn't know how to load native libraries.
}
_ => {
// Everything else doesn't know how to load native libraries.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo fix here ^

@hkBst

hkBst commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

I don't see how I broke (macos-latest, nightly)... maybe the object point release will help...

@workingjubilee workingjubilee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not your problem exactly but this should not land before we fix #758 and cut a release as I do not want a further MSRV change to become a precondition for a safety-related update. Thus I am filing this comment so that in later triage it becomes obvious there is something to address (...outside this PR).

@workingjubilee

Copy link
Copy Markdown
Member

Thanks past Jubilee!

@workingjubilee

Copy link
Copy Markdown
Member

tf? macos...

@workingjubilee

workingjubilee commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

I'm not sure my reasoning about the soundness concern holds, thinking about it, because the soundness concern is fairly "weak" (for a soundness concern) (that is, people are not in the habit of invoking resolve recursively and it's not an easily "induced" action), so it is a comparatively noncritical fix and we are likely going to be in a state of often having such a concern.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants