Skip to content

escape URL component in location header - #111

Closed
noraj wants to merge 1 commit into
ruby:masterfrom
noraj:patch-1
Closed

escape URL component in location header#111
noraj wants to merge 1 commit into
ruby:masterfrom
noraj:patch-1

Conversation

@noraj

@noraj noraj commented Feb 17, 2023

Copy link
Copy Markdown

brings non-ASCII (eg. Unicode) support

fix #110

@noraj
escape URL component in location header
1156c19 
brings non-ASCII (eg. Unicode) support
@jeremyevans

jeremyevans commented Feb 17, 2023

Copy link
Copy Markdown
Collaborator

If location is already correctly percent escaped, this would double escape it and break working code, which I don't think is acceptable.

@noraj noraj closed this Feb 17, 2023
@noraj

noraj commented Feb 17, 2023

Copy link
Copy Markdown
Author

Yeah this solution is too naive. A more global approach should be taken.

@noraj
noraj deleted the patch-1 branch February 17, 2023 17:44
@jeremyevans jeremyevans mentioned this pull request Feb 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unicode handling in header location

2 participants

@noraj @jeremyevans