Repository navigation
Refine memory leak tests - #36
Merged
Merged
Conversation
Repeated sampling avoids false leak reports from transient RSS growth.
Allow memory leak assertions to stop sampling when memory growth settles. This helps avoid failures from transient memory use.
On macOS, it sometimes takes a little while for a process attached to the debugger to be ready for `waitpid`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert_no_memory_leakcompared memory usage only before and after the test code ran. Temporary memory growth could cause intermittent failures, and a single comparison could not show whether growth continued or settled.Take repeated memory samples and check the growth trend. A sample range allows the assertion to stop early when growth settles while limiting the maximum number of samples.