Skip to content

Test failure: test_captures #82

Closed
Closed

Description

@olleolleolle

The changes in
1fbfdd3
fail on 3.2 and 3.3, it seems. ruby-head seems to pass this test.

Details

Failure looks like this:


Run ruby run-test.rb
Loaded strscan from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/3.2.0/x86_64-linux/strscan.so
Gem from 
Loaded suite run-test
Started
...F
===============================================================================
Failure: test_captures(TestStringScanner)
/home/runner/work/strscan/strscan/test/strscan/test_stringscanner.rb:751:in `test_captures'
     748:     s = create_string_scanner("Timestamp: Fri Dec 12 1975 14:39")
     749:     s.scan("Timestamp: ")
     750:     s.scan(/(\w+) (\w+) (\d+) (1980)?/)
  => 751:     assert_equal(["Fri", "Dec", "12", nil], s.captures)
     752:     s.scan(/(\w+) (\w+) (\d+) /)
     753:     assert_nil(s.captures)
     754:   end
<["Fri", "Dec", "12", nil]> expected but was
<["Fri", "Dec", "12", ""]>

diff:
? ["Fri", "Dec", "12", nil]
?                      ""  
?                      ???  
===============================================================================
/home/runner/work/strscan/strscan/test/strscan/test_stringscanner.rb:788: [BUG] Segmentation fault at 0x0000000000000014
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]

Activity

  1. olleolleolle commented on Jan 15, 2024

    @olleolleolle
    ContributorAuthor

    cc @naitoh Perhaps you know more?

    I saw this when I tried to update the CI to use the shared "ruby versions from a remote JSON" GitHub Actions action in #74.

  2. kou commented on Jan 15, 2024

    @kou
    Member

    It uses strscan in Ruby not installed by gem install strscan.gem explicitly.
    I think that this is a bug of RubyGems or something but I haven't looked into this yet...

  3. olleolleolle commented on Jan 15, 2024

    @olleolleolle
    ContributorAuthor

    @kou I see. In light of that, should we merge #74 now?

  4. kou commented on Jan 15, 2024

    @kou
    Member

    If the failed jobs are also failed on master with the same reason, I'm OK with it.

  5. olleolleolle commented on Jan 15, 2024

    @olleolleolle
    ContributorAuthor

    @kou Yes, I checked, and yep, it's with the same reason. I will merge it, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions