Repository navigation
Scanning methods that don't use Regexp don't clear named capture groups #135
Description
I noticed strange behaviour - #named_captures may return capture groups and #[] returns nil instead of raising IndexError in the following scenario:
- call a scanning method with a Regexp (with named capture groups)
- call a scanning method without a Regexp pattern (
#getch,#get_byteor#scan_until/#exist?/... with a String pattern) - call
#[]with a named capture group (used in the Regexp) and#named_captures
I would expect that #[] raises IndexError and #named_captures returns nil.
Example
require 'strscan'
s = StringScanner.new('Fri Dec 12 1975 14:39')
s.scan(/(?<wday>Fri)/)
p s.named_captures # => {"wday" => "Fri"}
p s["wday"] # => "Fri"
s.get_byte
p s.named_captures # => {"wday" => nil}
p s["wday"] # => nil
s["month"] # => undefined group name reference: month (IndexError)Wondering whether it's correct behaviour.
Activity
kou commentedon Feb 13, 2025
Good catch!
We should clear named captures.
kou commentedon Feb 20, 2025
@naitoh Do you want to work on this too?
naitoh commentedon Feb 20, 2025
Yes, I would like to try this issue, too.
Fix a bug that scanning methods that don't use Regexp don't clear nam…
Fix a bug that scanning methods that don't use Regexp don't clear nam…
Fix a bug that scanning methods that don't use Regexp don't clear nam…
Fix a bug that scanning methods that don't use Regexp don't clear nam…
Fix a bug that scanning methods that don't use Regexp don't clear nam…
[ruby/strscan] Fix a bug that scanning methods that don't use Regexp
[ruby/strscan] Fix a bug that scanning methods that don't use Regexp