Repository navigation
Conversation
Net::HTTP required the whole DNS resolver, which also reads the system DNS configuration at load time, only to match Resolv::IPv4::Regex and Resolv::IPv6::Regex when deciding whether to send SNI. Use the same inlined regexps as the copy vendored in RubyGems, so that the two stay identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following files are maintained in the following upstream repositories:
Please file a pull request to the above instead. Thank you! |
Member
Author
|
Superseded by 6095c59, which synced the same change from ruby/net-http#355. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require 'net/http'loads all ofresolv, a DNS resolver of about 3,700 lines that also reads the system DNS configuration at load time.Net::HTTP#connectuses it only forResolv::IPv4::RegexandResolv::IPv6::Regex, to decide whether to send SNI.I copied the regexps that the net-http vendored in RubyGems already inlines (ruby/rubygems@9f2bd5f66c), so the two copies stay identical. They accept the same strings as the resolv ones over 6 million generated inputs. A new test checks that
net/httpno longer definesResolv.Code that uses
ResolvorSecureRandomafter requiring onlynet/httpnow needs its ownrequire. Nothing in this repository relies on that. A few gems on rubygems.org useResolvthat way, such asfirespring_dev_commands.Generated with Claude Code