Skip to content

Rewrite Win32API class to Fiddle #494

Open

Description

@hsbt

There is no reason we use Win32API.rb instead of Fiddle directly.

https://github.com/ruby/reline/blob/master/lib/reline/windows.rb#L55

Activity

  1. headius commented on Jan 4, 2023

    @headius
    Contributor

    I mentioned this in a related issue (#484) and I support moving away from using the stdlib Win32API. The main complication is that the copy/paste code in windows.rb for non-JRuby uses fiddle, which is a little bit broken on JRuby.

    The code may be close to working, but I have not attempted it and I do not have a Windows machine on which to test currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions