Repository navigation
Use h2 for default section headings in Aliki - #1842
Merged
Merged
Conversation
Documentation previewCommit: |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Regression tests are needed for both default and named section heading levels.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates Aliki’s heading hierarchy to correctly represent default and named sections.
Changes:
- Uses
h2for default Constants, Attributes, and method headings. - Retains
h3beneath named section headings.
| File | Description |
|---|---|
lib/rdoc/generator/template/aliki/class.rhtml |
Selects heading levels based on whether the section is named. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
st0012
force-pushed
the
codex/aliki-default-h2
branch
from
October 5, 2026 00:25
8f81d82 to
dc2301b
Compare
st0012
pushed a commit
that referenced
this pull request
Oct 13, 2026
#1842 fixes the method group nesting by emitting h2 headings in the default section, so the TOC needs no special case for them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gxq9jGyjWoANhMZXRtssiu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
h2for the default Constants, Attributes, and method group headings in Aliki. This better follows W3C guidance on heading hierarchy and fixes their misleading nesting in “On This Page.”Keep
h3for headings inside named sections, where they sit below the section’sh2heading.Fixes #1822.