Repository navigation
Remove useless Reline::Key.new and update wrong comment for alt+d - #963
Merged
Merged
Conversation
st0012
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IRB sets one of the
dialog.trap_keytoReline::Key.new(nil, 0xE4, true). This has no meaning.It only matches to
"\xE4"when convert-meta is enabled in Reline. But Reline's convert-meta is not working.ruby/reline#710
Using
Reline::Key.new(nil, 0xE4, true)might be a blocker for reline refactoring. (Of course Reline still needs to support for a while)Alt+d unicodes
# The "∂" that appears when Alt+d in pressed on iTerm2.is wrong.iTerm2part is wrong.In mac keyboard, alt+d in many keyboard language source sends
∂in normal text field in GUI applications. Some keyboard language source sendsð. Few qwerty keyboard language source sends other unicode characters.For the same reason,
# The "ä" that appears when Alt+d is pressed on xtermshould be wrong, but I don't know the about the environment.