Skip to content

ci: run e2e in the playwright container image - #16

Merged
kelsos merged 1 commit into
mainfrom
ci/e2e-playwright-container
Oct 23, 2026
Merged

kelsos merged 1 commit into
mainfrom
ci/e2e-playwright-container

Conversation

@kelsos

@kelsos kelsos commented Oct 23, 2026

Copy link
Copy Markdown
Member

The e2e job installed browsers with playwright install --with-deps, which runs apt-get against the runner's Ubuntu mirror. On #15 the mirror served packages at a few kB/s and the job hit its 15 minute timeout before any test ran.

  • The job now runs in mcr.microsoft.com/playwright:v1.64.0-noble, pinned by digest. It ships the browser builds for @playwright/test 1.64.0 and their system libraries, so the install step is gone.
  • --user 1001 runs it as the runner user, which owns the workspace; Firefox does not run as root under the job's HOME.
  • The e2e step has its own 5 minute timeout.
  • Renovate groups the image with @playwright/test, since each image only carries the browsers its release drives.

Checked locally: zizmor (auditor) reports nothing, and the 42 e2e tests pass in the same image as uid 1001.

@kelsos
kelsos requested a review from a team as a code owner October 23, 2026 10:41
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.33%. Comparing base (42dc915) to head (621d444).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   69.33%   69.33%           
=======================================
  Files          41       41           
  Lines        1839     1839           
  Branches      432      432           
=======================================
  Hits         1275     1275           
  Misses        476      476           
  Partials       88       88           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The job installed browsers with --with-deps, which runs apt against the
runner's Ubuntu mirror. A slow mirror ran the job into its 15 minute
timeout before any test started.

The official image (v1.64.0-noble, pinned by digest) ships the browser
builds for @playwright/test 1.64.0 and their system libraries, so the
install step goes. It runs as uid 1001, the runner user that owns the
workspace. The e2e step gets its own 5 minute timeout, and Renovate
groups the image with @playwright/test so the two move together.
@kelsos
kelsos force-pushed the ci/e2e-playwright-container branch from a59a9df to 621d444 Compare October 23, 2026 11:14
@kelsos
kelsos merged commit 621d444 into main Oct 23, 2026
9 checks passed
@kelsos
kelsos deleted the ci/e2e-playwright-container branch October 23, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant