Repository navigation
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendRequest() only set CURLOPT_TIMEOUT inside the POST-with-data branch, so the GET requests used during login and session handling could hold a Nextcloud request open indefinitely when Roundcube accepted the connection but stopped responding, and no request had a connection timeout at all. This moves CURLOPT_TIMEOUT into the common cURL options and adds CURLOPT_CONNECTTIMEOUT so every request to the Roundcube instance is bounded. I did not have a Nextcloud plus Roundcube pair to hang on purpose, so this is verified by reading the request path and with php -l; the values match the ones proposed in the issue.
Fixes #72