Repository navigation
Updater::add to take ownership of FunctionDiagnosticTask #309
Description
I believe this should probably be supported:
diagnostic_updater::FunctionDiagnosticTask helm_diag(
"Helm", [&helm_report](diagnostic_updater::DiagnosticStatusWrapper & stat) {
stat.add("Modes", helm_report.getModeSummary());
stat.add("Halted", helm_report.getHalted());
});
diag_updater->add(std::move(helm_diag));Unfortunately, this doesn't work and segfaults when helm_diag goes out of scope.
Activity
[-]Updater::add to accept lambdas[/-][+]Updater::add to take ownership of FunctionDiagnosticTask[/+]ct2034 commentedon Sep 26, 2023
Thanks for your issue, @russkel.
Could you please describe what you are trying to achieve in more detail? What is
ivp_diag?Please feel free to provide a test that and / or implementation in a pull request.
russkel commentedon Sep 27, 2023
A mistake in my copy and paste, apologies. It should be
helm_diag.Okay. We (my colleague and I) were a bit surprised by the interface to the
diagnostic_updaterand felt it could probably be easier. We hope to improve this or at the very least have specific feature requests.