Skip to content

Refactor PidRos to use updated RTpublisher API (backport #673) - #688

Open
mergify[bot] wants to merge 1 commit into
jazzyfrom
mergify/bp/jazzy/pr-673
Open

mergify[bot] wants to merge 1 commit into
jazzyfrom
mergify/bp/jazzy/pr-673

Conversation

@mergify

@mergify mergify Bot commented Nov 2, 2026

Copy link
Copy Markdown

ros-controls/realtime_tools#573

Breaks public API as get_pid_state_publisher() is removed, but for what could this be used for?


This is an automatic backport of pull request #673 done by Mergify.

(cherry picked from commit 3657779)

# Conflicts:
#	control_toolbox/include/control_toolbox/pid_ros.hpp
@mergify mergify Bot added the conflicts label Nov 2, 2026
@mergify

mergify Bot commented Nov 2, 2026

Copy link
Copy Markdown
Author

Cherry-pick of 3657779 has failed:

On branch mergify/bp/jazzy/pr-673
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 3657779.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   control_toolbox/src/pid_ros.cpp
	modified:   control_toolbox/test/pid_ros_publisher_tests.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   control_toolbox/include/control_toolbox/pid_ros.hpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant