Repository navigation
Conversation
bgentry
force-pushed
the
bg/sqlite-jobcancel-notify
branch
2 times, most recently
from
September 27, 2026 22:55
b364abf to
c8903b6
Compare
bgentry
changed the title
SQLite cancellation notifications use `json_object`, which emits compact JSON while PostgreSQL's `json_build_object` text includes spaces. The same control event therefore has different payload bytes across drivers. Format the SQLite outbox payload with PostgreSQL's key order, spacing, and string escaping while keeping its transactional insertion path. Cover exact payload bytes, cancellation through independent SQLite clients, and direct driver cancellation with no control topic.
bgentry
force-pushed
the
bg/sqlite-jobcancel-notify
branch
from
September 27, 2026 22:56
c8903b6 to
f37dcf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite cancellation notifications added in #1398 use
json_object, which emits compact JSON. PostgreSQL'sjson_build_objectoutput includes spaces, so the same control event has different payload bytes across drivers. The existing worker test cancels from the client running the job, leaving cancellation from an independent client untested.Fix this by formatting the SQLite outbox payload to match PostgreSQL's key order, spacing, and JSON string escaping. The notification keeps the transactional insertion path added in #1398.
Add a byte-exact payload check with escaped queue characters, a two-client SQLite test where one client cancels work in the other, and a cross-driver case for an empty control topic.