realloc is 1 byte short #744

Activity

1. msmeissn commented on Apr 9, 2025

   

   msmeissn

   on Apr 9, 2025

   Last edited by msmeissn

   Author

   More actions

   also a bit below there is:

                                       sprintf(revlistentry->revocations +
                                                       revocationsp,
                                               "%s\\n", line); 
   

   weird, line might have a \n already, and is double backslash \n here correct? if this is double backslash n , it needs to be
   +3 above
2. dennis-tseng99 commented on Apr 13, 2025

   

   dennis-tseng99

   on Apr 13, 2025

   Last edited by dennis-tseng99

   Contributor

   More actions

   @msmeissn Thanks so much.
   I think +2, rather than +3, is good enough. Suppose line="abc\n" 4 bytes. realloc(...,strlen(line),2) will allocate 6 bytes which is capable of making sprintf() to add line=3 bytes ,'\' and 'n' 2 bytes pluses extra '\0' byte totally 6 bytes.
   ps: line is already removed its '\n' ahead of sprintf() by line[strlen(line) - 1] = 0;