Repository navigation
Fix the old version resolved when using Gradle 8.2+ - #4
Merged
Merged
Conversation
Collaborator
Author
nastra
reviewed
Jun 28, 2024
| import org.gradle.api.artifacts.result.DependencyResult; | ||
| import org.gradle.api.artifacts.result.UnresolvedDependencyResult; | ||
|
|
||
| import java.io.File; |
Collaborator
There was a problem hiding this comment.
can you run ./gradlew spotlessApply locally? This shouldn't be re-organizing the imports
| conf.setVisible(false); | ||
| }); | ||
| Configuration oldApiConfiguration = project.getConfigurations().detachedConfiguration(); | ||
| oldApiConfiguration.getDependencies().add(oldApiDependency); |
Collaborator
There was a problem hiding this comment.
nit: Maybe good to add a test (as a follow up after the release is also fine)
ajantha-bhat
approved these changes
Jun 30, 2024
Collaborator
|
I rebased the PR and fixed formatting before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
With Gradle 8.2+, the plugin doesn't detect any breaking change as it consider the same version for both old/new API.
After this PR
The plugin cleanly detects breaking change with Gradle 8.2+.
Possible downsides?
As it uses
externalConfigurationsthe only downside could be the configuration caching is limited.