Skip to content

Case insensitive header names #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeyzimarev merged 2 commits into from
Feb 11, 2022
Merged

Case insensitive header names #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3512af4
Test strange-cased content headers
Feb 7, 2022
4910473
Support strange-cased content headers
Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/RestSharp/Request/RequestContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,17 @@ class RequestContent : IDisposable {
readonly List<Stream> _streams = new();

internal static readonly string[] ContentHeaders = {
Allow, Expires,
ContentDisposition, ContentEncoding, ContentLanguage, ContentLength, ContentLocation, ContentRange, ContentType, ContentMD5,
LastModified
Allow.ToLower(),
Expires.ToLower(),
ContentDisposition.ToLower(),
ContentEncoding.ToLower(),
ContentLanguage.ToLower(),
ContentLength.ToLower(),
ContentLocation.ToLower(),
ContentRange.ToLower(),
ContentType.ToLower(),
ContentMD5.ToLower(),
LastModified.ToLower(),
};

HttpContent? Content { get; set; }
Expand Down Expand Up @@ -172,7 +180,7 @@ void AddPostParameters(ParametersCollection? postParameters) {

void AddHeaders() {
var contentHeaders = _request.Parameters
.Where(x => x.Type == ParameterType.HttpHeader && ContentHeaders.Contains(x.Name))
.Where(x => x.Type == ParameterType.HttpHeader && ContentHeaders.Contains(x.Name?.ToLower()))
.ToArray();

if (contentHeaders.Length > 0 && Content == null) {
Expand Down Expand Up @@ -208,4 +216,4 @@ public void Dispose() {
_streams.ForEach(x => x.Dispose());
Content?.Dispose();
}
}
}
18 changes: 18 additions & 0 deletions test/RestSharp.Tests/RestContentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
using System.Net;

namespace RestSharp.Tests;

public class RestContentTests {
[Fact]
public void RestContent_CaseInsensitiveHeaders() {
var myContentType = "application/x-custom";
var request = new RestRequest("resource");
request.AddHeader("coNteNt-TypE", myContentType);
var client = new RestClient();
var content = new RequestContent(client, request);

var httpContent = content.BuildContent();

Assert.Equal(myContentType, httpContent.Headers.ContentType.MediaType);
}
}