DownloadStreamAsync and server error #2057

Activity

1. alexeyzimarev commented on Apr 7, 2023

   

   alexeyzimarev

   on Apr 7, 2023

   Member

   More actions

   Have you tried setting ThrowOnAnyError to true? I looked at the Download code and it will throw in your case.
2. nssoft-rlagrange commented on Apr 7, 2023

   

   nssoft-rlagrange

   on Apr 7, 2023

   Last edited by nssoft-rlagrange

   Author

   More actions

   I don't have this property on 108.
   I found a workaround by settings the AfterRequest delegate :

   Exception sharedException = null;
   request.OnAfterRequest = (response) => // capture exception
   {
   	try
   	{
   		response.EnsureSuccessStatusCode();
   	}
   	catch(Exception e) { sharedException = e; }
   	return new ValueTask(Task.FromResult(response.Content));
   	
   };
   using (var str = await client.DownloadStreamAsync(request, token))
   {
   	if (sharedException != null) throw sharedException; // fire captured exception
   	await str.CopyToAsync(fs);
   }
   
3. nssoft-rlagrange

   closed this as completedon Apr 7, 2023
4. alexeyzimarev commented on Apr 7, 2023

   

   alexeyzimarev

   on Apr 7, 2023

   Last edited by alexeyzimarev

   Member

   More actions

   ThrowOnAnyError is the client option that exists since v107. Before that it was the client property.

   https://restsharp.dev/error-handling.html
5. nssoft-rlagrange commented on Apr 7, 2023

   

   nssoft-rlagrange

   on Apr 7, 2023

   Last edited by nssoft-rlagrange

   Author

   More actions

   Ok i found the property. It doesn't work, at least in my 108 version.
   No exception thrown, at the very least the stream is empty, so I could check the length.
   My workaround work fine.
6. alexeyzimarev commented on Apr 7, 2023

   

   alexeyzimarev

   on Apr 7, 2023

   Member

   More actions

   It was fixed by this PR #1962. I am not sure what version was release after that.