Repository navigation
New setting VERSATILEIMAGEFIELD_CRASH_ON_BAD - #124
Closed
litchfield wants to merge 4 commits into
Closed
litchfield wants to merge 4 commits into
litchfield wants to merge 4 commits into
Conversation
tuky
suggested changes
Aug 29, 2018
tuky
left a comment
tuky
left a comment
There was a problem hiding this comment.
I agree, that this module is too generous towards errors. May I request some changes?
- code coverage decreased. we probably need a test for the exception code path
VersatileImageFieldWarmer._prewarm_versatileimagefieldcan still swallow all exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a large production deployment, we found some image files were crashing PIL. We didn't like that, and neither did our users.
New setting, VERSATILEIMAGEFIELD_CRASH_ON_BAD, default True to match current behaviour.
Set it to False, and it will (won't?) do what it says on the tin. Crises (plural) averted. It'll still raise a warning though, in case you're interested.