You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
vim-mode-change not fired on command mode enter/exit #251
Vim would consider command mode (entered via : as a first-class mode itself) - however it seems code-mirror vim is not eventing this mode transition out - i'm having to manually track it, would it make sense to emit this? There are multiple calls to vim-mode-change but never for command mode?
I also noticed some any types when digging around this code on handler of vim-mode-change I suspect this could be typed stricter, but don't want to expand the scope of this issue too much.
As for the types, yeah it's not great, a lot of the code was ported from the codemirror 5 codebase which was not typed, we tried to type most things, but feel free to fix those as well.
Activity
masad-frost commentedon Jul 29, 2026
Yeah feel free to submit a PR.
As for the types, yeah it's not great, a lot of the code was ported from the codemirror 5 codebase which was not typed, we tried to type most things, but feel free to fix those as well.