[sayalibhavsar]

Volume and attachment names in disks.tf were using the raw var.run_label, which can exceed IBM's 63-character naming limit. Changed to use local.name_prefix instead, which is consistently used across other resources in main.tf and is properly capped to stay within the limit per the 63-character comment in main.tf.

This Solves: #533
relates to Jira: RPOPC-1583

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e8d7148b-9016-4b13-9c15-333d56f83779

📥 Commits

Reviewing files that changed from the base of the PR and between 5d2e950 and d5afec1.

📒 Files selected for processing (1)

• ansible_roles/roles/ibm_create/files/tf/disks.tf

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Summary

Summary by CodeRabbit

• Chores
  • Volume and instance-volume attachment names now follow the configured name prefix. Existing name suffixes and index formatting remain unchanged. This may affect how these resources are labeled in infrastructure views; no other user-facing changes are included.

Walkthrough

The IBM disk volume and attachment names now use local.name_prefix instead of var.run_label. Their suffixes and formatted indexes remain unchanged.

Changes

IBM disk resource naming

Layer / File(s)	Summary
Use the name prefix for disk resources ansible_roles/roles/ibm_create/files/tf/disks.tf	The volume and attachment names now use local.name_prefix. Their suffixes and formatted indexes are unchanged.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to d5afe

Disk names now use the capped shared prefix and remain below IBM’s 63-character limit for ordinary resource counts. No actionable merge risk is established.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Issue #533 requires IBM volume names to use the length-capped local.name_prefix instead of raw var.run_label. The PR changes the volume and instance-volume attachment names in `ansible_roles/roles…
Out of Scope Changes check	✅ Passed	The reported changes are limited to the volume and instance-volume attachment name prefixes in disks.tf. These changes directly support the naming requirement in issue #533. No unrelated change is i…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Title check	✅ Passed	The title clearly describes the switch to a length-capped name prefix for IBM volume names. It omits attachment names, but still identifies the main change.
Description check	✅ Passed	The description summarizes the change, gives the before-and-after behavior, and identifies issue #533 and JIRA RPOPC-1583. It does not answer the Documentation Check section explicitly.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}