Skip to content

(WIP) feat(server-params): further define common server params - #195

Closed
gsdevme wants to merge 1 commit into
reactphp:masterfrom
gsdevme:feat-support-more-server-params
Closed

gsdevme wants to merge 1 commit into
reactphp:masterfrom
gsdevme:feat-support-more-server-params

Conversation

@gsdevme

@gsdevme gsdevme commented May 28, 2017 •

Copy link
Copy Markdown

Marking this is a WIP for now, need to further look at the best way to get SCRIPT_FILENAME.. somewhat might not be possible.. unless its passed as an option or defined elsewhere... if nothing else I think it should be set to an empty string though due to #192

'SCRIPT_FILENAME'
The absolute pathname of the currently executing script.
  • HTTP_HOST
  • SCRIPT_FILENAME
  • HTTP_USER_AGENT
  • Should HTTPS be set to an empty string on non-https? (think so)
  • Convert to long array Syntax to support an unsupported PHP version from 8 years ago

https://secure.php.net/manual/en/reserved.variables.server.php

@clue

clue commented Jan 6, 2018

Copy link
Copy Markdown
Member

Thank you for digging into this and filing this PR! 👍

I still think that getting this feature in makes perfect sense and I'm looking forward to a future update here!

Given that this is currently a WIP and hasn't seen any updates in a while and I don't see it's likely this will get traction any time soon, I will have to close this for now. Please don't see this as discouraging, we would still love to get this feature in and very much appreciate your effort! You can simply complete this feature and update this PR and we're happy to reopen this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants