Skip to content

Add Version and HttpVersionPolicy support for HttpRequestMessage - #1800

Merged
ChrisPulman merged 17 commits into
reactiveui:mainfrom
infofromca:HttpVersionPolicy
Sep 15, 2024
Merged

ChrisPulman merged 17 commits into
reactiveui:mainfrom
infofromca:HttpVersionPolicy

Conversation

@infofromca

Copy link
Copy Markdown
Contributor

Fixes #1799

@TimothyMakkison

Copy link
Copy Markdown
Collaborator

I've never used Http version before but is there a usecase for setting the version for different requests. Perhaps by decorating an interface function with [HttpVersion(<version here>)].

@infofromca

infofromca commented Aug 31, 2024 •

Copy link
Copy Markdown
Contributor Author

I think it is not neccessary to have [HttpVersion()] , it is easy ( understanding) and resilience to Add Version and HttpVersionPolicy to the settings .

@infofromca infofromca closed this Sep 8, 2024
@infofromca infofromca reopened this Sep 8, 2024
@ChrisPulman
ChrisPulman enabled auto-merge (squash) September 15, 2024 23:52
@ChrisPulman
ChrisPulman merged commit e6f075e into reactiveui:main Sep 15, 2024
@codecov

codecov Bot commented Sep 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.74%. Comparing base (6ebeda5) to head (d171ac1).
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
- Coverage   87.73%   83.74%   -3.99%     
==========================================
  Files          33       36       +3     
  Lines        2348     2449     +101     
  Branches      294      345      +51     
==========================================
- Hits         2060     2051       -9     
- Misses        208      316     +108     
- Partials       80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Oct 3, 2024

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Version and HttpVersionPolicy support for HttpRequestMessage for Http 3

3 participants