Skip to content

feat: added generator tests - #1765

Merged
ChrisPulman merged 1 commit into
reactiveui:mainfrom
TimothyMakkison:generator_test
Jul 25, 2024
Merged

ChrisPulman merged 1 commit into
reactiveui:mainfrom
TimothyMakkison:generator_test

Conversation

@TimothyMakkison

Copy link
Copy Markdown
Collaborator

Redo of #1753, this time focusing on individual cases.

  • Added some basic tests.
  • I intend to keep InterfaceStubGenerator in the main tests to target the latest version of .NET framework if possible. I'm trying not to use unsafe code in a rewrite, but if I do .NET Framework will have to be handled uniquely.
  • Using this in my source generator rewrite, I'm trying to split it into smaller PRs so I don't dump a massive change on you.
  • Got a pr with Verify.SourceGenerator to add a way to ignore certain files. I'd like to use it on the duplicate PreserveAttribute.cs files.

@TimothyMakkison
TimothyMakkison marked this pull request as ready for review July 25, 2024 21:43
@codecov

codecov Bot commented Jul 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (6ebeda5) to head (71d9653).
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
- Coverage   87.73%   83.58%   -4.15%     
==========================================
  Files          33       36       +3     
  Lines        2348     2431      +83     
  Branches      294      343      +49     
==========================================
- Hits         2060     2032      -28     
- Misses        208      316     +108     
- Partials       80       83       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman reopened this Jul 25, 2024
@ChrisPulman
ChrisPulman merged commit 923b961 into reactiveui:main Jul 25, 2024
@github-actions

github-actions Bot commented Aug 9, 2024

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants