Skip to content

Change parser config to accept regex in exclude symbols field. (#56367) - #56367

Closed
coado wants to merge 5 commits into
react:mainfrom
coado:export-D99844594
Closed

coado wants to merge 5 commits into
react:mainfrom
coado:export-D99844594

Conversation

@coado

@coado coado commented Apr 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Adds support for regex in the exclude_symbols field in the C++ API parser config. This enables better scoped definitions of symbols that should be matched.

Changelog:
[Internal]

Reviewed By: huntie

Differential Revision: D99844594

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Apr 8, 2026
@meta-codesync

meta-codesync Bot commented Apr 8, 2026

Copy link
Copy Markdown

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99844594.

Dawid Małecki added 4 commits April 8, 2026 04:39
Summary:
Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot.

Changelog:
[Internal]

Differential Revision: D99434605
Summary:
Excludes all symbols and members that consists of `DO_NOT_USE`, like

- findComponentViewWithTag_DO_NOT_USE_DEPRECATED
- propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN
- setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN
- findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN
- componentViewName_DO_NOT_USE_THIS_IS_BROKEN
- ensurePlaceholderIfEmpty_DO_NOT_USE

Changelog:
[Internal]

Differential Revision: D99834673
Summary:
Excludes symbols  marked as `deprecated`, such as:

- viewRegistry_DEPRECATED
- DEPRECATED_sendUpdatedChildFrames
- nativeProps_DEPRECATED
- findShadowNodeByTag_DEPRECATED
- setNativeProps_DEPRECATED

from the C++ public API snapshot.

Differential Revision: D99838523
…apshot.

Summary:
Excludes categories marked as `Deprecated` and `Internal` from the ReactApple C++ public API snapshots.

Chagnelog:
[Internal]

Differential Revision: D99838922
@meta-codesync meta-codesync Bot changed the title Change parser config to accept regex in exclude symbols field. Change parser config to accept regex in exclude symbols field. (#56367) Apr 8, 2026
Summary:
Pull Request resolved: #56367

Adds support for regex in the `exclude_symbols` field in the C++ API parser config. This enables better scoped definitions of symbols that should be matched.

Changelog:
[Internal]

Reviewed By: huntie

Differential Revision: D99844594
@meta-codesync meta-codesync Bot closed this in b60f0c9 Apr 9, 2026
@facebook-github-tools facebook-github-tools Bot added the Merged This PR has been merged. label Apr 9, 2026
@meta-codesync

meta-codesync Bot commented Apr 9, 2026

Copy link
Copy Markdown

This pull request has been merged in b60f0c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant