Repository navigation
Conversation
|
By analyzing the blame information on this pull request, we identified @mkonicek, @kmagiera and @andreicoman11 to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
There was a problem hiding this comment.
Rather than checking for this specific ordering of options, it'd be more robust to start with no paint flags, split the string on spaces (so we get an array of options), and apply them each to the bitmask so we'd support "line-through underline" and potentially also combinations with "overline" one day.
It looks like the iOS side is similarly constrained but it seems like a good change to make.
There was a problem hiding this comment.
I did consider that, but I weighed precise compatibility with the iOS side as more valuable than the future flexibility. It prevents an Android developer from writing a style (eg. 'line-through underline') that works only on Android without being aware of it.
That said, I'd be happy to add compatible flexible parsing to both platforms. Do you think it would make sense to include that change in this PR?
There was a problem hiding this comment.
Good point about x-platform parity. Would you like to submit a follow-up PR that adds flexible parsing to Android and iOS? That'd be awesome!
|
Maybe close this PR in favor of #3819. Discussion is happening there. |
|
Yeah. As the other PR mentions, this one can be closed. |
4 participants
Attached PR adds support for the none, underline, line-through, and 'underline line-through' textDecorationLine style elements to Android, and, updates the UIExplorer to display these options.
Note that textDecorationColor and textDecorationStyle have not been added as well because there is no straight-forward way to support these options in Android.