Skip to content

TextInput claims the responder on every selection change, even with no active touch #58445

Open

Description

@msageryd

Description

Where: Libraries/Components/TextInput/TextInput.js, onSelectionChangeShouldSetResponder={emptyFunctionThatReturnsTrue} (line 607 on main today), with {...otherProps} spread before it so a caller cannot override.

What happens: the claim exists for drag-selection with a finger down, but it fires for every selection change the plugin walks, including ones caused by typing, whenever the plugin's touch counter is above zero (see react/react#37571 for how that counter drifts). The focused input then holds the JS responder with no touch active, and the next tap outside it is dropped.

Fix: claim only while event.touchHistory.numberActiveTouches > 0, and let a caller pass their own onSelectionChangeShouldSetResponder. Verified in an app patch on RN 0.85.3.

Proposed change (against main, packages/react-native/Libraries/Components/TextInput/TextInput.js, line 607 in InternalTextInput). Claim only while there is an active touch, and let a caller override:

         onSelectionChange={_onSelectionChange}
-        onSelectionChangeShouldSetResponder={emptyFunctionThatReturnsTrue}
+        // The claim exists for drag-selection with a finger down. Typing
+        // also changes the selection, and with no touch active the input
+        // must not take the responder, or the next tap outside it is dropped.
+        onSelectionChangeShouldSetResponder={
+          props.onSelectionChangeShouldSetResponder ??
+          (e => (e?.touchHistory?.numberActiveTouches ?? 0) > 0)
+        }
         selection={selection}

The same line appears once more in the Android branch of the same file. We run this in production through patch-package against React Native 0.85.3.

Steps to reproduce

As described above

React Native Version

0.85.3

Affected Platforms

Runtime - iOS

Output of npx @react-native-community/cli info

System:
  OS: macOS 26.5.1
  CPU: (12) arm64 Apple M2 Max
  Memory: 264.73 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 24.11.0
    path: /Users/michaelsageryd/.nvm/versions/node/v24.11.0/bin/node
  Yarn: Not Found
  npm:
    version: 11.3.0
    path: /Users/michaelsageryd/dev/plantrail/client/plantrail_mobile/node_modules/.bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.16.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 25.5
      - iOS 26.5
      - macOS 26.5
      - tvOS 26.5
      - visionOS 26.5
      - watchOS 26.5
  Android SDK:
    API Levels:
      - "31"
      - "35"
      - "36"
      - "36"
    Build Tools:
      - 35.0.0
      - 36.0.0
      - 36.1.0
      - 37.0.0
    System Images:
      - android-36 | Google Play ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2025.3 AI-253.32098.37.2534.15232325
  Xcode:
    version: 26.6/17F113
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.18
    path: /Library/Java/JavaVirtualMachines/zulu-17.jdk/Contents/Home/bin/javac
  Ruby:
    version: 3.4.7
    path: /opt/homebrew/opt/ruby@3.4/bin/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 20.1.0
    wanted: 20.1.0
  react:
    installed: 19.2.3
    wanted: 19.2.3
  react-native:
    installed: 0.85.3
    wanted: ^0.85.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: true

Stacktrace or Logs

No trace

MANDATORY Reproducer

Reproducer: #58449

Screenshots and Videos

No response

Activity

  1. react-native-bot commented on Sep 10, 2026

    @react-native-bot
    Collaborator

    Warning

    Missing reproducer: We could not detect a reproducible example in your issue report. Reproducers are mandatory and we can accept only one of those as a valid reproducer:


    You can read more about about it on our website: How to report a bug.

  2. msageryd commented on Sep 10, 2026

    @msageryd
    Author

    Reproducer: #58449

  3. msageryd commented on Sep 10, 2026

    @msageryd
    Author

    Reproducer is PR #58449, the repro bot could not clear the label.

  4. DigitalAndSEO commented on Oct 11, 2026

    @DigitalAndSEO

    Additional observation on React Native 0.86.3 / iOS / Fabric

    We independently observed the TextInput behavior described here after a two-finger gesture in an existing app.

    Environment:

    • React Native 0.86.3 with Fabric
    • Expo SDK 57.0.27
    • React Native Gesture Handler 2.32.0
    • A physical iPhone 16

    Reproduction in our app:

    1. Activate a pinch gesture after placing the two fingers separately.
    2. Close the gesture view and open a dialog containing a TextInput and an action button.
    3. Edit the input and dismiss the keyboard.
    4. Tap the action button.

    The button action does not run on the first tap. Instead, the input regains focus and the keyboard reopens. The behavior can persist after leaving and reopening the form; an app reload clears it until another triggering gesture.

    Touch traces showed two separate start events followed by a single cancellation containing both fingers, with no active touches remaining. This matches the triggering sequence discussed in react/react#37571.

    Important distinction: we have not tested the TextInput change proposed in #58477. We applied only the related responder-counter correction from react/react#37700, leaving TextInput unchanged. That correction eliminated the observed first-tap/refocus behavior in our repeated physical-device tests.

    Sharing this as additional evidence that the reported symptom is not isolated. This report comes from an existing app, not a standalone minimal reproducer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: TextInputRelated to the TextInput component.Needs: AttentionIssues where the author has responded to feedback.Needs: ReproThis issue could be improved with a clear list of steps to reproduce the issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions