You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am wondering if it is possible to perform an eslint check during continuous integration to ensure that the coding guidelines are maintained by developers.
Activity
excitement-engineer commentedon Oct 15, 2016
Specifically for the javascript code. I want CI to be able to catch the warnings in the linter such as the following example:
Do you know if this is currently possible?
mxstbr commentedon Oct 15, 2016
Sorry, deleted my comment, my brain was still in the wrong project so it didn't make any sense. 😊
I haven't done that so I'm not sure, sorry!
excitement-engineer commentedon Oct 15, 2016
hahaha no worries!
gaearon commentedon Oct 15, 2016
I think linting should be a part of
npm run buildon CI environments.There is an issue for this: #440.
Would you like to send a PR?
Let's enable this only if
process.env.CIis"true".Otherwise local builds will be annoyingly slow.
It's fine to totally abort the build on CI if there are any lint warnings, but not locally.
excitement-engineer commentedon Oct 15, 2016
Yes I will send a PR, I will try to find some time to fix this next week:) Thanks a lot for your help and quick response!
karlhorky commentedon Dec 4, 2016
Can this be closed now that #944 is merged?
mxstbr commentedon Dec 4, 2016
Yes! Thanks @karlhorky
karlhorky commentedon Dec 4, 2016
Np, thanks for all the work on this!